furl icon indicating copy to clipboard operation
furl copied to clipboard

Restore metadata to the furl module

Open gruns opened this issue 4 years ago • 5 comments

Before v2.0.0:

>>> import furl
>>> print(furl.__version__)
'2.0.0'

With v2.1.0:

>>> import furl
>>> print(furl.__version__)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'furl' has no attribute '__version__'

The other metadata attributes are missing, too: __version__, __license__, etc.

gruns avatar Jul 02 '20 20:07 gruns

hey can I work on this?

yellalena avatar Oct 02 '20 11:10 yellalena

I guess they just removed those variables from the __init__.py and put it in the __version__.py. They might need to add an __all__ variable to let the user get this metadata.

ThatXliner avatar Oct 02 '20 15:10 ThatXliner

Absolutely! Pull requests welcome.

@ThatXliner Yep; the metadata was lost in the migration to __version__.py

gruns avatar Oct 02 '20 17:10 gruns

@gruns The main code is in furl.py, right? So I just need to add __all__ = ["furl", "__version__"] unless some of the implementation are in the other files.

ThatXliner avatar Oct 02 '20 18:10 ThatXliner

Not sure; that might do it.

If

>>> import furl
>>> furl.__version__
2.1.0

works, you did it :smiley:

gruns avatar Oct 06 '20 05:10 gruns