Ansgar Grunseid

Results 110 comments of Ansgar Grunseid

I have no problem with an optional `colorama` dependency, per se. But let's back up quickly to make sure we're all on the same page and tackling the right problem....

Thank you for expounding; I understand your predicament much better now. ```It's a very useful security feature, but pipenv always pushes colorama's platform marker into lock-file``` This is the money...

Marking `colorama` as `platform_system=='Windows'` in setup.py should do the trick nicely and avoid runtime `if sys.platform.startswith('win'):` checks. * https://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-platform-specific-dependencies One problem: I don't have ready access to a Window machine...

Example with larger dicts exhibits less-than-optimal formatting: ```python from icecream import ic from random import choice from string import ascii_letters as letters randomWord = lambda: ''.join(choice(letters) for i in range(10))...

Actually just ran into another organic example just now: `ic(os.environ)`: ```python import os from icecream import ic ic(os.environ) ``` Output: ```python ic| os.environ: environ({'PWD': ... a really long, not-pretty-printed, single-line...

I'll think about this more, too. I created the Issue yesterday so the potential improvement wouldn't get lost.

> According to the standard the sort function should return a value > than 0 or < than 0 or 0. Not a boolean, which is the current result of...

> May be the simplest approach is to make the user responsible of the inconsistencies, by clearly stating that keys and values should always be strings. yep. this is exactly...

> A user can't set a value to undefined, right? right. ignore my first comment `undefined` means the key hasn't been `set()` or was `remove()`d

1) is this with the latest ImmortalDB v1.1.0? 2) please provide minimal code to reproduce the error so i can see exactly what you see these `window` checks may not...