pcsx-redux icon indicating copy to clipboard operation
pcsx-redux copied to clipboard

All Typed Debugger `New value` input fields share underlying value

Open Fuuzetsu opened this issue 2 years ago • 2 comments

I'm on 77d97eb28999d4b8f865653f505b9bed143d2b48

If you load a data type and change one field, all of the values in all the input fields change.

Looking at the code, this is because they all write to m_newValue private member so it's not surprising.

Presumably we need input text storage for each label and have them all be separate. Maybe a map from address to value or whatever.

Fuuzetsu avatar Apr 25 '23 07:04 Fuuzetsu

Yeah, this is actually a surprisingly awkward thing to deal with in Dear ImGui; I remember trying to give each field an individual value but it broke something (using the Enter key to confirm the value, I think it was) and I didn't pursue it further. Would definitely be worth having, though, because the shared value is counter-intuitive.

twevs avatar Apr 25 '23 15:04 twevs

I'll give it a go at some point I think, the existing behaviour is a bit too painful 😣

Fuuzetsu avatar Apr 25 '23 16:04 Fuuzetsu