pcsx-redux icon indicating copy to clipboard operation
pcsx-redux copied to clipboard

Some options are not properly backed up

Open wheremyfoodat opened this issue 2 years ago • 5 comments

  • [❌] Window settings (Maximization and x/y/w/h) seem to not persist sometimes as per #1110
  • [❌] Memory editor settings don't persist as per #1108 and #1092
  • [❌] Assembly window settings don't persist as per #1091

wheremyfoodat avatar Nov 30 '22 18:11 wheremyfoodat

Are these three issues that you are working on them and you decided to put all of them here in a single issue? Brilliant! You are smarter than me!

ghost avatar Nov 30 '22 19:11 ghost

One setting that might need addressed in this issue is the m_fullscreen variable of gui.h I don't believe this setting is saved, and it might be beneficial to treat the window position variables as separate if m_fullscreen = true.

As is, if you exit the emulator while in full screen mode, a reboot opens in a windowed view that appears fullscreen - as in, the emulator's Title Bar and sizing border are hidden/stretched outside of the viewable area.

johnbaumann avatar Nov 30 '22 20:11 johnbaumann

Are these three issues that you are working on them and you decided to put all of them here in a single issue? Brilliant! You are smarter than me!

All of us are a bit short on time these days so I don't think somebody is working on these at this very moment. However they should eventually be fixed. Grouping similar issues (ie issues that are of a similar nature like this one, or issues that concern a specific widget, etc) is a pretty similar practice as it avoids creating too many issues and flooding the issues tab, burying other people's issues.

It's similar to being in a classroom. You are free to speak, but it's important to make sure the other students get to be heard too.

wheremyfoodat avatar Nov 30 '22 20:11 wheremyfoodat

Are these three issues that you are working on them and you decided to put all of them here in a single issue? Brilliant! You are smarter than me!

All of us are a bit short on time these days so I don't think somebody is working on these at this very moment. However they should eventually be fixed. Grouping similar issues (ie issues that are of a similar nature like this one, or issues that concern a specific widget, etc) is a pretty similar practice as it avoids creating too many issues and flooding the issues tab, burying other people's issues.

It's similar to being in a classroom. You are free to speak, but it's important to make sure the other students get to be heard too.

You are correct. I also realized that these issues are similar and had to be grouped. You did the right thing and I know that you are not always available.

ghost avatar Dec 01 '22 00:12 ghost

One setting that might need addressed in this issue is the m_fullscreen variable of gui.h I don't believe this setting is saved, and it might be beneficial to treat the window position variables as separate if m_fullscreen = true.

As is, if you exit the emulator while in full screen mode, a reboot opens in a windowed view that appears fullscreen - as in, the emulator's Title Bar and sizing border are hidden/stretched outside of the viewable area.

I am not playing fullscreen but only windowed. I don't even know how to play in fullscreen and if this is possible at all. I like the window maximized while playing but this is not fullscreen.

ghost avatar Dec 01 '22 00:12 ghost