grug
Websocket Support
We have had a need to mock a WS server at OVO using this library. This work implements that.
This looks pretty solid. I'll give this a run when I'm at my desktop tomorrow. I really appreciate contributions like this out of the blue!
@grug
This looks pretty solid. I'll give this a run when I'm at my desktop tomorrow. I really appreciate contributions like this out of the blue!
You're welcome. We needed to mock websockets any way and it didn't make sense two sets of mocking infra
Aiden I need to see a dank meme before I can approve this work.
It will take a long time to find a suitably dank meme for a PR of this calibre. Now I can see there is an appetite to upstream this I will more than likely clean this up on my next 10pc day next friday
@hamishdixon morley has aske me to remind you that you are a flim-flam
I'm going to have to run this stuff locally and see how it all works as I feel like people can get pretty fancy with their websocket setups so I want to see how this stands up against some weird configurations.
@aidenscott2016 are you still okay with all of this? I'm thinking of merging and releasing today :)