aparato
aparato copied to clipboard
PCI ID wrong parse
Hi,
Thanks for for your crate. I've been testing it with mixed results as in two systems the hw listed seems ok but the other one the results are wrong. I looked at you code and found the error on the set_*_name() functions for device and subsystem.
The parser generate not valid results due to the following bugs in your code when parsing pci id file:
- Device name: Vendor is not considered (first step in decoding should be to locate the vendor section in the file) & the parsing do not discard '\t\t' lines that describe subystems.
- Subsystem name: Vendor ins not considered as in the device name.
I think these bugs are easy to fix. I can do a PR but I don't know if you are working on that as I see that you have a open PR to address accuracy.
I'll take all the help I can get :)
I've been quite busy maintaining some of my other projects so I couldn't get around to finishing up #10