User-Style-Manager icon indicating copy to clipboard operation
User-Style-Manager copied to clipboard

Add ability to import Stylish User Styles into USM

Open grssam opened this issue 12 years ago • 14 comments

grssam avatar Oct 07 '12 18:10 grssam

Why do you set higher priority to the less important things? The syntax parser is still working with bugs and the corresponding issue got P3 priority, while this one got P1.

Drugoy avatar Oct 09 '12 20:10 Drugoy

I must say, two things lead to it : Many people wanting a better UI for Managing Styles. This one is easier to implement. I want to make Stylish's users feel like home, as they are used to that kind of UI.

(Sorry it went to three :P )

grssam avatar Oct 09 '12 20:10 grssam

Well, you can convert Stylish users to USM users by suggesting new yummy features, but they have to work without bugs to be yummy. This issue is about making the process of migration itself be easier, but users won't migrate to a place without yummies... Due to some bugs in USM I still have to keep Stylish for now, so I have 3 (USM, Stylish, Stylish-Custom) extensions now instead of 1 (USM) :(

Drugoy avatar Oct 09 '12 21:10 Drugoy

I agree. And the parser related issues are my next priorities. you might have noticed that there are no P2. That is because just after v1.0 release I shifted the P2 to P1, but did not do that for P3, so basically just after UI modifications, My next goal would be to make the parser perfect.

grssam avatar Oct 09 '12 21:10 grssam

That sounds great :) As for this issue: please, do not forget when importing the styles from Stylish that some of them may have been installed from userstyles.org. If the user has done some local changes to such a style - USM will just run a comparison between the style's code and the code at install_URL of the style and it will notice the difference and suggest the user to update the style. I'm not aware of what the default setting for styles' updates now, but you should definitely make USM at least ask prompt the user for permission to update those styles, or users might lose their codes and they will be angry at USM for that. Just warning.

Drugoy avatar Oct 09 '12 21:10 Drugoy

I would directly read from the local styles, their url, their name and then import it. So if user has any local changes, they will be ported as well.

grssam avatar Oct 09 '12 21:10 grssam

After they get ported - USM will once in a while check for updates for them. And since styles' get update based on the comparison of codes (instead of comparison of versions) - USM will define, that there are updates available for them. As far as I can judge,checkbox "Update -> Automatically" is checked by default (WHICH IS WRONG!!!), thus, the styles will get updated and the codes will get lost. I think you should turn automatic updates off by default.

Drugoy avatar Oct 09 '12 21:10 Drugoy

No, starting from version 1.0, I have an internal flag to know local changes. So until and unless you have "Update > Overwrite local changes" checked, it will not automatically update the styles that you changed locally.

While it might sometimes falsely identify local changes, say a user deleted something , saved, and then next time put it back, it should work for all the normal use cases.

One note: Since there was no such flag before version 1.0, some styles might get overwritten when the first time auto update happens.

Also, Stylish also maintains such flag, so I will know while porting, which styles are locally changed.

grssam avatar Oct 09 '12 22:10 grssam

That sounds promising. However, I have a few question regarding how the updates work. What does "Automatically" checkbox actually do? If it is checked - will the styles get updated silently? Or will they just run automated checking for updated, but will still require user interaction? If the answer is that they will get updated silently - then I'd like to request a setting "ask for user confirmation". If the answer is that even with that checkbox checked - user interaction is needed - then I'll request an option for silent updates :)

Drugoy avatar Oct 09 '12 22:10 Drugoy

Well, update automatically means automatically, without bothering the user. May be having the preference you want is a good point.

grssam avatar Oct 09 '12 22:10 grssam

"Automatically" means "not manually" and just that. What you did is "automatically + silently". Then the question is how will USM behave if the user has unchecked that checkbox: will USM don't look for the updates at all or will it still check for the updates, but require user interaction?

What I suggest is to create three input with tуpe="radio" settings, instead of a checkbox as it is now. I remind, that only one of the "radio" buttons may be selected at one moment. These 3 settings should be "Update silently", "Require confirmation" and "Turn updates off". Currently you have only 1st and the 3rd settings. I hope you mean what I wrote, as it's no so simple to explain.

Drugoy avatar Oct 09 '12 22:10 Drugoy

Any progress on this? I've accumulated overtime a massive amount of styles in stylish. Would love to import them over.

nhantrn avatar Feb 22 '13 06:02 nhantrn

Girish appears to be busy at this time, therefore there are not going to be important modifications until he becomes available again. We'll have to wait ;)

alopepeo avatar Feb 22 '13 14:02 alopepeo

Indeed I am, but I really want to work on this soon. Lets see.

grssam avatar Feb 22 '13 14:02 grssam