wow-addon-updater
wow-addon-updater copied to clipboard
grrttedwards
Move config parsing into own class
This moves the parsing of the "config.ini" into its own class and allows certain options to be optional. This useful for multiple reasons:
- Reduces complexity of AddonManager
- Allows options to be parsed before AddonManager is initiated
The reason I propose this change is, because I would like the ability to turn off the self updater (#84), which would mean parsing the options earlier. Rather than moving it to "main.py" I feel it would be most appropriate to have it as its own class.
I see what you did there ;)
I don’t have time to review this probably today, but I like the idea a lot! The config externalization was on my list, but I haven’t been spending a ton of time on the code since I finished splitting off the site module, so I’m more than happy you’re helping!!
I am pretty sure there is a humorous bingo of git beginner mistakes that people make constantly and I am close to a bingo :(
The Travis error is weird. I just did a clean clone and install of the branch on another device on another network and it works fine. "test_integration_github_get_latest_version" fails which has nothing to do with this commit since I didn't touch that file.
Nice change. Most of my comments are just pointing out that there are a ton of formatting changes that aren't necessarily needed -- my personal opinion is that extra noise like that is very bad in PR's
The Travis error is weird. I just did a clean clone and install of the branch on another device on another network and it works fine. "test_integration_github_get_latest_version" fails which has nothing to do with this commit since I didn't touch that file.
Yeah something is funky with GitHub, and I'm seeing that fail pretty frequently now. Created an issue for it #90 and fixed #92