proposal icon indicating copy to clipboard operation
proposal copied to clipboard

Published 20 hours ago • verified publisher icon grpc

A34 `weighted_round_robin` lb_policy for per endpoint weight from `ClusterLoadAssignment` response

Open yishuT opened this issue 4 years ago • 10 comments

yishuT avatar Aug 17 '20 05:08 yishuT

CLA Check
The committers are authorized under a signed CLA.

  • :white_check_mark: Yi-Shu Tai (0b0adb05affbf9a0aad26dfed3ab71faf4411e7f, 519d3ab2411d594c575b9b37e4d236e4ac46a2ba)

linux-foundation-easycla[bot] avatar Aug 17 '20 05:08 linux-foundation-easycla[bot]

Please fix the commit to include your user ID, as per the EasyCLA check above.

markdroth avatar Aug 17 '20 15:08 markdroth

Hey, would like to hear an update even you think this proposal is far from the roadmap. I personally have some cycles in coming weeks to make this proposal aligned with grpc roadmap.

yishuT avatar Sep 07 '20 23:09 yishuT

cc @menghanl

dfawley avatar Sep 08 '20 23:09 dfawley

Thanks for all the feedback. I will post another update to address all of them next couple of days. Please feel free to leave any comments in the meantime.

yishuT avatar Sep 14 '20 04:09 yishuT

soft ping. any udpates?

yishuT avatar Oct 14 '20 04:10 yishuT

@markdroth I want to revisit this proposal. Does gRPC community have any plan for per endpoint weight LB policy? If there is no other active proposal or plan, I can resume the work this month

yishuT avatar May 14 '22 23:05 yishuT

We don't have any other plan to do this, so if it's still something you'd like, please feel free to continue moving this design forward.

markdroth avatar May 16 '22 16:05 markdroth

I am confused about the status of this proposal. It is not yet merged, but looks like we are already using endpoint weights, at least in grpc-go.

  • Here EDS response is parsed and weights are stored.
  • Next we use the weight property to configure weighted round robin LB in the EDS (clusterresolver) load balancer link
  • We also use those weights in the ringhash EDS implementation link

s-matyukevich avatar Jan 30 '23 20:01 s-matyukevich

Hey @s-matyukevich

afaik, weights are stored but grpc client does not have weighted round robin implemented for every language. The proposal is to have a unified protocol for implementation.

yishuT avatar Jan 30 '23 20:01 yishuT