grpc icon indicating copy to clipboard operation
grpc copied to clipboard

gRPC: Add grpc_authorization_provider to CMake

Open jebr224 opened this issue 3 years ago • 4 comments

The CMake is missing a build library, and this patch adds it. This library exist in the bazel.

Signed-off-by: John Edward Broadbent [email protected]

jebr224 avatar Sep 29 '22 17:09 jebr224

Request testing labels.

jebr224 avatar Oct 07 '22 17:10 jebr224

Request testing labels.

jebr224 avatar Oct 07 '22 20:10 jebr224

I skimmed over the changes and the changes to add the grpc_authorization_provider library seem fair, as long as that's actually a library that is supposed to be public and to be distributed/installed along with the grpc C++.

@veblush should know the answers to these questions.

also let's doublecheck the test results, since lots of them seem to be failing.

jtattermusch avatar Oct 10 '22 14:10 jtattermusch

This window test might be relevant to this PR?

  t:\altsrc\github\grpc\workspace_cpp_windows_x86_cmake_as_externalproject\src\core\lib\matchers\matchers.h(28): fatal error C1083: Cannot open include file: 're2/re2.h': No such file or directory (compiling source file 

veblush avatar Oct 10 '22 16:10 veblush

grpc_authorization_provider cmake target seems to miss ${_gRPC_RE2_LIBRARIES}. Since it's a bit hard to tweak CMakeLists.txt.template, you can consider working on CMakeLists.txt first without modifying its template file. This will break sanity test but it'd be much easier to fix it once you get a working CMakeLists.txt with other tests.

veblush avatar Nov 14 '22 17:11 veblush

Closing in favor of https://github.com/grpc/grpc/pull/31308

veblush avatar Nov 15 '22 18:11 veblush