grpc.github.io icon indicating copy to clipboard operation
grpc.github.io copied to clipboard

Published 20 hours ago • verified publisher icon grpc

update node docs to use addService

Open mitchdraft opened this issue 6 years ago • 5 comments

small change to the docs now that the node server api has changed

link to api: https://github.com/grpc/grpc-node/blob/master/packages/grpc-native-core/src/server.js#L948

the examples work with or without this change, but the change removes this warning message:

$ node server.js
(node:44083) DeprecationWarning: Server#addProtoService: Use Server#addService instead

mitchdraft avatar Nov 10 '18 13:11 mitchdraft

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

  • User @mitchdraft isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards, CLA GitHub bot

thelinuxfoundation avatar Nov 10 '18 13:11 thelinuxfoundation

CLA signed

mitchdraft avatar Nov 10 '18 13:11 mitchdraft

The change seems fine to me too. @murgatroid99 can you please take a look?

ZhouyihaiDing avatar Nov 13 '18 23:11 ZhouyihaiDing

@murgatroid99 @nicolasnoble can you please rubber stamp, given that this is an example change it would be best if one of you looked over it.

hsaliak avatar Dec 05 '18 23:12 hsaliak

@murgatroid99 @nicolasnoble @hsaliak are we OK to merge this one?

thisisnotapril avatar Apr 08 '19 23:04 thisisnotapril