grpc-web icon indicating copy to clipboard operation
grpc-web copied to clipboard

Add AbortSignal support to unary calls

Open emil14 opened this issue 4 years ago • 5 comments

With callback client I can do

const call = client.method(request, meta, cb)

While Promise client doesn't give that call but I need it to call.cancel() in the Timeout


BTW another question - Am I have to do that? I want to cancel my call if it exceeded the timeout, but in my meta I have deadline. Will grpc-web cancel my call for me or I have to do it manually? If it does, will promice reject with timeout error?

Thank you!

emil14 avatar Sep 01 '20 11:09 emil14

Hi! Thanks for the interests here!

As mentioned in https://github.com/grpc/grpc-web/pull/1240#issuecomment-1260136406, i will try to experiment with this feature internally first soon, and upstream it to GH if it works. Thanks!

sampajano avatar Oct 25 '22 07:10 sampajano

Any updates on this?

maja42 avatar Sep 04 '23 11:09 maja42

@maja42 Hi thanks for checking!

I intended to do this but was not able to prioritize it yet..

i'll again bump this in my list and i hope to get to it in the upcoming weeks!

sampajano avatar Sep 05 '23 21:09 sampajano

@sampajano it's been a year since the initial PR requesting/adding it. Is there anything needed to help start moving with this thing?

kanekv avatar Oct 05 '23 16:10 kanekv

@kanekv You're right! I'll really try to work on this soon! Apologize for the delays!

sampajano avatar Oct 13 '23 01:10 sampajano