grpc-swift icon indicating copy to clipboard operation
grpc-swift copied to clipboard

Fix connection timeout when retries are set to none

Open afeick opened this issue 2 years ago • 3 comments

Motivation:

Connection timeout is ignored on last retry or when retries are set to none (issue #1649)

Modifications:

Use the minimumConnectionTimeout value from the ConnectionBackoff directly instead of the ConnectionBackoffIterator

Results:

Connection timeout is honored across all connection attempts.

afeick avatar Sep 20 '23 05:09 afeick

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: tfeickjc / name: Tony Feick (d9f0db41b78c6f134a230873cb69d0194d45444a)
  • :white_check_mark: login: afeick / name: Anthony Feick (7e97e1beab165a72818e70dc569c6d1e1b4c4c1c, 349ddd7b24e92a3fff29a910f4b5751d54aba519, 3f39bec1ba506fda53769637dfee3ee2761f93fa, 03d23a6a4e9583e374f8e231cb2ccd67e9dbcd37)

This is slightly more awkward than I first realised.

Same. I missed that the timeout can increase with the backoff. Not sure how I didn't see that because I was looking for where it might change, given the variable name minimumConnectionTimeout.

afeick avatar Sep 22 '23 19:09 afeick

This is slightly more awkward than I first realised.

Same. I missed that the timeout can increase with the backoff. Not sure how I didn't see that because I was looking for where it might change, given the variable name minimumConnectionTimeout.

Yeah, it's only really an issue for the final value though; the solution I outlined above should be sufficient here.

glbrntt avatar Sep 25 '23 07:09 glbrntt