grpc-php icon indicating copy to clipboard operation
grpc-php copied to clipboard

Add compatibility for php 8.4 by removing deprecation warnings

Open PNardman opened this issue 10 months ago • 3 comments

Feature or problem being solved

Adding explicit nullable to parameters since implicit nullable parameters are deprecated in PHP 8.4

Affected code:

Status::L35 Satus::L47 ServerCallWrite::L94

Further details

Adding the explicit nullable parameter, gets rid of unnecessary deprecation warnings for php 8.4, however since we need to support php 7 we need to remove the type hinting, since php 7 does not support this feature.

Links / references

Implicitly nullable values are deprecated in php 8.4.

See: https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

PNardman avatar Feb 18 '25 11:02 PNardman

CLA Missing ID CLA Not Signed

  • :x: The email address for the commit (1ed55b39638fd07d2e0922bb8d80da24fd868ba1) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

I think we should differentiate the (major) version to support 8.4 instead of removing the typing, and drop the support for php7?

shu-yusa avatar Feb 20 '25 07:02 shu-yusa

since php versions 7.x and 8.1 have reached EOL (https://www.php.net/supported-versions.php), how's dropping the support of 7.0 - 8.1, and publish the release as 2.0.0 for example? what do you think? cc: @stanley-cheung

shu-yusa avatar Feb 25 '25 02:02 shu-yusa