grpc-node

grpc-node copied to clipboard

This is another attempt at fixing #2718. The previous attempt, #2680, failed because of #2690. I believe I have fixed that this time. With the original change, I reproduced a...

murgatroid99

fix: support authority overrides in the DNS resolver

5

As per issue https://github.com/grpc/grpc-node/issues/2775, this pr adds support for overriding the authority on DNS resolver.

gkampitakis

Implement authority overrides in the DNS resolver

6

### Is your feature request related to a problem? Please describe. We have use cases where we would like to use the DNS resolver with a DNS server that is...

atollena

grpc-loader: Expose field options

3

### Is your feature request related to a problem? Please describe. In our proto files we would like to use custom options on field level (see [FieldOptions in descriptor.proto](https://github.com/protocolbuffers/protobuf/blob/433ca3e/src/google/protobuf/descriptor.proto#L637-L802)) to...

n0v1

Servers send grpc-message trailer even when no error

1

The [gRPC protocol spec](https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md#requests) has this to say about the “grpc-message” trailer, which is optional (unlike “grpc-status”): > The value portion of **Status-Message** is conceptually a Unicode string description of...

jhump

According to the [gRPC docs for compression](https://github.com/grpc/grpc/blob/master/doc/compression.md), when a client or server sends a “grpc-encoding” header with an unrecognized/unsupported encoding the recipient MUST report that as an error. A client...

jhump

Server does not check the HTTP method of the request

2

If the rest of the request looks like a gRPC request, the server will accept incorrect HTTP methods, such as “DELETE” or “PUT”. If the server generates an error status,...

jhump

Servers base64-encode “grpc-status-details-bin” header with padding, but should be unpadded

1

The spec for gRPC states that implementations should emit binary headers using *unpadded* base64-encoding (emphasis mine): > Note that HTTP2 does not allow arbitrary octet sequences for header values so...

jhump

When response stream includes messages and then an error, final message(s) can be dropped

1

If the server sends back a sequence of response messages (in a server-stream or bidi-stream RPC) followed by an error status, the client can miss the final message in the...

jhump

Discussion: Why HTTP2 pseudo headers such as :authory are removed from Metadata

1

I'm curious to learn more about the reasons behind removing HTTP2 pseudo headers from being exposed as gRPC Metadata members on server call handlers. In my case, I'm specifically interested...

davidfiala