grpc-kotlin icon indicating copy to clipboard operation
grpc-kotlin copied to clipboard

Switch to bazelmod

Open ratnikov opened this issue 1 year ago • 11 comments
trafficstars

Resolves https://github.com/grpc/grpc-kotlin/issues/398

I'm open to which version to pick, just happy I can depend on grpc-kotlin using bazel mod. :)

ratnikov avatar Jun 08 '24 02:06 ratnikov

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: ratnikov / name: Dmitry Ratnikov (b72ec86492d9f3fad41590d83b3e3e7ce87ed112, b7419dfdef7bcc63f968ad666fd651debd9283b5, e29b53f8f7437e8d8c1d8722aa98bfc59fbf3c3f)

@ratnikov I was just lurking on the issue that this patch is targeted towards. Is there an alternative/competing patch thats not listed on the issue? Nice work regardless, it would be good to see bzlmod support. Hopefully you're able to get the CLA and stuff and find a reviewer 😄 🤞

ed-irl avatar Jul 19 '24 18:07 ed-irl

I'm not aware of any alternative work. I've been using my patch internally for a bit, so so far it works. :)

We've been making some progress on our end to get the EasyCLA hurdle out of the way, so I'm hopping that that will be green in a week or two. I have a feeling that may elicit some input from maintainers on its mergability.

ratnikov avatar Jul 19 '24 18:07 ratnikov

Is anything blocking review of this? It seems the CLA has been signed.

gonzojive avatar Oct 22 '24 03:10 gonzojive

@lowasser hey, looks like you merged last few commits. Could you help me understand what's the best process to follow to proceed with the review of this PR?

ratnikov avatar Oct 22 '24 12:10 ratnikov

Ready to merge?

gonzojive avatar Dec 13 '24 17:12 gonzojive

@gonzojive Yes. Waiting for maintainers to take action and unblock running of the checks (or unblock merging in a different way).

ratnikov avatar Dec 13 '24 20:12 ratnikov

👋 bzlmod user here. I tried the techniques seen here in my project and things seem like they are working. Thanks for the great work.

blockjon-dd avatar Jan 03 '25 17:01 blockjon-dd

@lowasser - Any movement on this? (also, hi!)

cgruber avatar Mar 13 '25 04:03 cgruber

@ratnikov Thanks for this work. (bzlmod user here and also blaze user as I am a Googler :P) . Eagerly waiting for this PR to be merged from past few months. I can use the same tech-stack which I am currently used-to in Google for fullstack development.

stack-plumber avatar Mar 27 '25 14:03 stack-plumber

Friendly /poke from another googler. :wave:

dougthor42 avatar Jun 23 '25 20:06 dougthor42

Is this going ahead? Bazel 9 is coming and soon workspace will not be feasible at all.

jack-bradshaw avatar Aug 10 '25 23:08 jack-bradshaw

Hey everyone - some good news. Initial bzlmod support has now been merged. Definitely, a huge thanks to @ratnikov for getting the ball rolling on this, and to everyone here for pushing it forward. While not merged, part of the info in this PR were definitely reflected in #640. Right now, you can test it with something like:

bazel_dep(name = "grpc_kotlin", version = "0.0.0")

git_override(
    module_name = "grpc_kotlin",
    commit = "de050e0bbef2c8acc1050697a0ee39afcf651858",
    remote = "https://github.com/grpc/grpc-kotlin.git",
)

As you may have guessed, the real maintainers are fully occupied with their primary work. To clarify, I am not real maintainer, but just have temporary permissions :). I would like to see this to the end, hopefully getting it released to the Bazel registry.

In the meantime (probably the next 1-2-3 weekends), while I can't approve my own PRs (so hard to make things better on my own), I can review yours =)). if you see some bugs or improvements and willing and able to make some very simple and short changes that can be quickly verified, I am happy to review and merge them to make this better. Especially @ratnikov, I'll prioritize your PRs if any. ;) Thanks.

duckladydinh avatar Aug 23 '25 18:08 duckladydinh