grpc-java icon indicating copy to clipboard operation
grpc-java copied to clipboard

Published 20 hours ago • verified publisher icon grpc

core: round_robin to use acceptResolvedAddresses()

Open temawi opened this issue 3 years ago • 3 comments

Switching to new API to allow eventual deprecation of handleResolvedAddresses()

temawi avatar Sep 19 '22 21:09 temawi

@ejona86 It does not check and fail on empty address lists because they are actually supported. You can see a test exercising this scenario here: https://github.com/grpc/grpc-java/blob/7665d3850b9c3063372beae2fda4a604379bce22/core/src/test/java/io/grpc/util/RoundRobinLoadBalancerTest.java#L243

temawi avatar Oct 10 '22 21:10 temawi

I don't think it is actually supported. It reports TRANSIENT_FAILURE, but it looks like it will queue all RPCs. It will essentially just hang, which is no good.

ejona86 avatar Oct 10 '22 22:10 ejona86

I don't think it is actually supported. It reports TRANSIENT_FAILURE, but it looks like it will queue all RPCs. It will essentially just hang, which is no good.

Updated to check for empty addresses and I also fixed a test that was making wrong assumptions.

temawi avatar Oct 11 '22 20:10 temawi