grpc-java icon indicating copy to clipboard operation
grpc-java copied to clipboard

Rls spec sync

Open larry-safran opened this issue 3 years ago • 1 comments

rls: Update implementation to match spec.

  • Cleanup cache if exceeds max size when add an entry. Make cache entry size calculations more accurate
  • Trigger pending RPC processing if unexpired backoff entries were removed from the cache by triggering helper to call it's parent updateBalancingState with the same state and picker
  • Introduce minimum time before eviction (5 seconds)
  • Change default accept ratio for AdaptiveThrottler from 1.2 -> 2.0
  • Configuration validation
    • When checking key names for duplicates also look at headers
    • Check extra keys for duplicates

See analysis of implementation versus spec at https://docs.google.com/spreadsheets/d/18w5s1TEebRumWzk1pvWnjiHFGKc6MW-vt8tRLY4eNs0/

larry-safran avatar Aug 10 '22 22:08 larry-safran

I think @temawi is secondary for RLS, so I think it would be best for him to review. If you also want me to review, that is fine, but I'll let temawi take the first pass.

FYI, checkstyle is failing.

ejona86 avatar Aug 11 '22 16:08 ejona86