grpc-java
grpc-java copied to clipboard
grpc
Avoid flushing headers when the server returns a single response
The history has gotten convoluted here and seems broken, and is breaking the diff. Are you fine with me cleaning it up? (Doing so will require force-pushing to the branch, and I'm not entirely sure if I have access to do that but I can certainly try.)
@amirhadadi Would you please complete the EasyCLA and rebase to resolve the conflicts?
@larry-safran as we traced the issue of extra segments being sent to flow control PINGs, not sure it's worth merging this PR. WDYT? Should it be closed?
With https://github.com/grpc/grpc-java/pull/9847 , we won't be sending PINGs as frequently, especially for small requests/responses on a warmed connection.
Seems this wasn't merged just waiting on @sanjaypujare's review.
With #9847 , we won't be sending PINGs as frequently, especially for small requests/responses on a warmed connection.
Seems this wasn't merged just waiting on @sanjaypujare's review.
Yes, I noticed that a couple of days ago. Is there still interest in merging this PR? From yours and @amirhadadi 's comments I am guessing this PR may not be needed anymore. Let me know
My comment was to say this has use, as the thing that made it less useful has been fixed. (And even back when it didn't demonstrate a win, I was approving of it.)
Okay. @amirhadadi do you want to rebase then I will review. 3 files have conflicts