grpc-java icon indicating copy to clipboard operation
grpc-java copied to clipboard

async server: need to ignore unary response msg if status is not OK

Open ejona86 opened this issue 6 years ago • 2 comments

The expectation for unary responses is that the server will respond with an message or an error. If the server responds with a message and an error, the message should be thrown away. The async API currently would send the message. For unary responses, we should delay sending the response until the onComplete()/onError(). If onError() is called we should not send the message.

https://github.com/grpc/grpc-java/blob/b22017851560197a41015acd90f443f7b9519984/stub/src/main/java/io/grpc/stub/ServerCalls.java#L336-L349

See #5968 and grpc/grpc#12824

ejona86 avatar Jul 09 '19 22:07 ejona86

I working on this issue and analysis is progress.

Alam-Saran avatar Aug 29 '24 09:08 Alam-Saran

@kannanjgithub I started my initial investigation to this defect and found there is no steps how to reproduce it at my local,Can you please suggest me the reprodicing steps of this defect.

Alam-Saran avatar Aug 29 '24 09:08 Alam-Saran