grpc-java icon indicating copy to clipboard operation
grpc-java copied to clipboard

Make service config more explicit

Open voidzcy opened this issue 6 years ago • 2 comments

Currently when a service config is supplied, we do not know if things are configured correctly as we desired. Service configs are applied silently. This makes it hard to know what goes wrong when using a service config. For example, in #5724, a retry service config is supplied by user but does not correctly applied to the service since the service name in the config was wrong. User sees nothing but retry is not happening. Is it possible to give out some information about what's going on when there is a service config?

voidzcy avatar May 17 '19 18:05 voidzcy

@ejona86 do you have any plan to provide object-oriented API for retries? current way in #5724 looks error prone to me - setting up configuration by untyped hashmaps will make compiler silent when API will be changed

eugeniyk avatar Feb 21 '20 11:02 eugeniyk

@eugeniyk, there is no plan for a typed API. Service config is designed to be transported via JSON, so the normal case is there is no typed API.

ejona86 avatar Feb 24 '20 17:02 ejona86