Tracking Issue for HealthStatusManager

[carl-mastrangelo]

[chabmed]

Hi, maybe it's not a bug I just need some clarification about the health check, https://github.com/grpc/grpc/blob/master/doc/health-checking.md, it's mentioned that the empty string should be used as the key for server's overall health status. But inside the code i'm not seeing anything special using empty string, and when querying the helthStatus check with empty string, i receive UNKNOWN_SERVICE. I want to use this rpc for the readinessProbe in kubernetes. i'm seeing in the master branch (1.17.0) the class HealthStatusManager

/**

• The special "service name" that represent all services on a GRPC server. It is an empty
• string. */ public static final String SERVICE_NAME_ALL_SERVICES = "";

But it's not used. Am I missing something here, I know it's still an experimental API, should I implement my own non grpc health check in this case? Thanks,

[carl-mastrangelo]

@chabmed : this issue is for the API, not the implementation. In the future, can you please open questions in https://groups.google.com/forum/#!forum/grpc-io ?

cc: @zhangkun83

[zhangkun83]

This is answered on https://groups.google.com/d/msg/grpc-io/mfEc57yGLr0/mSjyz8p7BgAJ

[larry-safran]

Stabilize except for existing setStatus which uses a generated class as an argument. Create a new setStatus that uses our own enum. Change getHealthService javadoc to remove "created in the constructor"