grpc-java icon indicating copy to clipboard operation
grpc-java copied to clipboard

Context.Storage is experimental

Open zhangkun83 opened this issue 9 years ago • 6 comments

This is the tracking issue that will be closed once Context.Storage API exits experimental status.

zhangkun83 avatar Nov 30 '16 05:11 zhangkun83

This allows people to change where the values are stored instead of the default ThreadLocal. Used in G3 for ... complex stuff. Also used for other things. Might want additive changes.

larry-safran avatar Jul 12 '23 18:07 larry-safran

Context.Storage.attach() isn't used by anyone in our repo or G3 and can be deleted with Context.Storage.doAttach being marked abstract.

larry-safran avatar Jul 12 '23 18:07 larry-safran

On hold since other repos (e.g. Vert.x and OpenTelemetry) depend on Context, may not be safe to delete deprecated method.

tonyjongyoonan avatar Jul 12 '23 19:07 tonyjongyoonan

The following query gets all of the usages. Should be checked to ensure that none of them are really using attach . https://sourcegraph.com/search?q=context:global+class+ContextStorageOverride+lang:java&patternType=standard&sm=0&groupBy=repo

larry-safran avatar Jul 12 '23 20:07 larry-safran

Quarkus.io is the only repo that uses attach().

It is not used anywhere but the override would throw an error if the method is deleted.

tonyjongyoonan avatar Jul 12 '23 22:07 tonyjongyoonan

The API is still labeled as experimental.

ejona86 avatar Nov 13 '23 15:11 ejona86