grpc-java icon indicating copy to clipboard operation
grpc-java copied to clipboard

Backend Service Metric implementation should change for A75 Aggregate Cluster Fixes

Open ejona86 opened this issue 2 months ago • 0 comments

https://github.com/grpc/proposal/blob/master/A75-xds-aggregate-cluster-behavior-fixes.md#changes-to-backend-service-metric-label-plumbing

gRFC A89 Backend Service Metric Label has a different implementation approach dependent on whether this gRFC has been implemented. If A89 was implemented before this gRFC, then backend service plumbing needs to change to go through the cds policy instead of the xds_cluster_impl policy, as documented in A89.

It doesn't appear this change was done: https://github.com/grpc/grpc-java/blob/096c4d9f915fcbef342311a794378194f526bd54/xds/src/main/java/io/grpc/xds/ClusterImplLoadBalancer.java#L403

https://github.com/grpc/grpc-java/blob/096c4d9f915fcbef342311a794378194f526bd54/xds/src/main/java/io/grpc/xds/ClusterImplLoadBalancer.java#L156-L162

ejona86 avatar Oct 21 '25 18:10 ejona86