stats/opentelemetry: record retry attempts from clientStream
Fixes: https://github.com/grpc/grpc-go/issues/8299
RELEASE NOTES:
- stats/opentelemetry: Retry attempts (
grpc.previous-rpc-attempts) are now recorded as span attributes for non-transparent client retries.
Codecov Report
:x: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 81.50%. Comparing base (e60a04b) to head (c0e523c).
:warning: Report is 1 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| stats/opentelemetry/client_tracing.go | 52.63% | 6 Missing and 3 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #8342 +/- ##
==========================================
- Coverage 81.64% 81.50% -0.15%
==========================================
Files 413 413
Lines 40621 40693 +72
==========================================
- Hits 33167 33166 -1
- Misses 5991 6000 +9
- Partials 1463 1527 +64
| Files with missing lines | Coverage Δ | |
|---|---|---|
| stats/opentelemetry/opentelemetry.go | 50.94% <ø> (-26.97%) |
:arrow_down: |
| stats/opentelemetry/trace.go | 41.07% <ø> (-47.82%) |
:arrow_down: |
| stats/opentelemetry/client_tracing.go | 55.31% <52.63%> (-32.19%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@vinothkumarr227 there is a failure in the updated test reported by codecov: https://github.com/grpc/grpc-go/actions/runs/16616024027/job/47008766111?pr=8342
PTAL and ensure the test is not flaky.
@vinothkumarr227 there is a failure in the updated test reported by
codecov: https://github.com/grpc/grpc-go/actions/runs/16616024027/job/47008766111?pr=8342PTAL and ensure the test is not flaky.
Sure, I’ll check it out.
@vinothkumarr227 there is a failure in the updated test reported by
codecov: https://github.com/grpc/grpc-go/actions/runs/16616024027/job/47008766111?pr=8342PTAL and ensure the test is not flaky. Hi @arjan-bal , I tested the test locally and everything passed consistently. I’ve now merged the latest changes from master, and all test cases are passing.