grpc-go
grpc-go copied to clipboard
Add List method to gRPC Health service
This change introduces a new List RPC endpoint for the Health service, allowing clients to retrieve the statuses of all monitored services. This feature simplifies integration with status-reporting dashboards and enhances observability for microservices.
Proposal: https://github.com/grpc/proposal/pull/468 gRPC-proto change: https://github.com/grpc/grpc-proto/pull/143
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.15%. Comparing base (
4cedec4) to head (8ea3d54). Report is 18 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #8155 +/- ##
==========================================
+ Coverage 82.08% 82.15% +0.06%
==========================================
Files 417 419 +2
Lines 41344 41988 +644
==========================================
+ Hits 33936 34494 +558
- Misses 5972 6023 +51
- Partials 1436 1471 +35
| Files with missing lines | Coverage Δ | |
|---|---|---|
| health/server.go | 95.65% <100.00%> (+0.65%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.
@marcoshuck could you resolve the merge conflicts?
Could you run ./scripts/vet.sh to catch vet errors and fix them?
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.
Could you run
./scripts/vet.shto catch vet errors and fix them?
I did, however I cannot find the root cause for the vet error, any advice?
Could you run
./scripts/vet.shto catch vet errors and fix them?I did, however I cannot find the root cause for the vet error, any advice?
goimports -l . is reporting that the imports in health/server_internal_test.go need to be formatted. You should be able to fix it using the following command:
goimports -w ./health/server_internal_test.go
Could you run
./scripts/vet.shto catch vet errors and fix them?I did, however I cannot find the root cause for the vet error, any advice?
goimports -l .is reporting that the imports inhealth/server_internal_test.goneed to be formatted. You should be able to fix it using the following command:goimports -w ./health/server_internal_test.go
That did the trick, thank you!
Filed #8276 for the flake. And we can ignore the vet-proto error - we need to regenerate our proto messages, but not in this PR.
@marcoshuck 2 more small comments. Thanks.
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.