grpc-go icon indicating copy to clipboard operation
grpc-go copied to clipboard

Add List method to gRPC Health service

Open marcoshuck opened this issue 8 months ago • 3 comments
trafficstars

This change introduces a new List RPC endpoint for the Health service, allowing clients to retrieve the statuses of all monitored services. This feature simplifies integration with status-reporting dashboards and enhances observability for microservices.

Proposal: https://github.com/grpc/proposal/pull/468 gRPC-proto change: https://github.com/grpc/grpc-proto/pull/143

marcoshuck avatar Mar 08 '25 15:03 marcoshuck

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.15%. Comparing base (4cedec4) to head (8ea3d54). Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8155      +/-   ##
==========================================
+ Coverage   82.08%   82.15%   +0.06%     
==========================================
  Files         417      419       +2     
  Lines       41344    41988     +644     
==========================================
+ Hits        33936    34494     +558     
- Misses       5972     6023      +51     
- Partials     1436     1471      +35     
Files with missing lines Coverage Δ
health/server.go 95.65% <100.00%> (+0.65%) :arrow_up:

... and 52 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 08 '25 15:03 codecov[bot]

This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.

github-actions[bot] avatar Mar 19 '25 22:03 github-actions[bot]

@marcoshuck could you resolve the merge conflicts?

purnesh42H avatar Mar 28 '25 19:03 purnesh42H

Could you run ./scripts/vet.sh to catch vet errors and fix them?

purnesh42H avatar Apr 14 '25 06:04 purnesh42H

This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.

github-actions[bot] avatar Apr 22 '25 22:04 github-actions[bot]

Could you run ./scripts/vet.sh to catch vet errors and fix them?

I did, however I cannot find the root cause for the vet error, any advice?

marcoshuck avatar Apr 27 '25 20:04 marcoshuck

Could you run ./scripts/vet.sh to catch vet errors and fix them?

I did, however I cannot find the root cause for the vet error, any advice?

goimports -l . is reporting that the imports in health/server_internal_test.go need to be formatted. You should be able to fix it using the following command:

goimports -w ./health/server_internal_test.go

arjan-bal avatar Apr 28 '25 06:04 arjan-bal

Could you run ./scripts/vet.sh to catch vet errors and fix them?

I did, however I cannot find the root cause for the vet error, any advice?

goimports -l . is reporting that the imports in health/server_internal_test.go need to be formatted. You should be able to fix it using the following command:

goimports -w ./health/server_internal_test.go

That did the trick, thank you!

marcoshuck avatar Apr 28 '25 18:04 marcoshuck

Filed #8276 for the flake. And we can ignore the vet-proto error - we need to regenerate our proto messages, but not in this PR.

dfawley avatar Apr 28 '25 20:04 dfawley

@marcoshuck 2 more small comments. Thanks.

purnesh42H avatar Apr 29 '25 10:04 purnesh42H

This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.

github-actions[bot] avatar May 05 '25 10:05 github-actions[bot]