grpc-go
grpc-go copied to clipboard
xds/internal: provide xDS node ID in control plane errors
To fix internal b/364405720 ("Provide xDS node id in control plane errors (Golang)").
RELEASE NOTES: none
Codecov Report
Attention: Patch coverage is 62.06897% with 11 lines in your changes missing coverage. Please review.
Project coverage is 82.12%. Comparing base (
66ba4b2) to head (a3c0554). Report is 2 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| xds/internal/balancer/cdsbalancer/cdsbalancer.go | 55.55% | 8 Missing :warning: |
| xds/internal/resolver/xds_resolver.go | 72.72% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #7909 +/- ##
==========================================
+ Coverage 82.04% 82.12% +0.07%
==========================================
Files 377 377
Lines 38180 38192 +12
==========================================
+ Hits 31326 31365 +39
+ Misses 5551 5532 -19
+ Partials 1303 1295 -8
| Files with missing lines | Coverage Δ | |
|---|---|---|
| xds/internal/resolver/xds_resolver.go | 79.75% <72.72%> (+0.37%) |
:arrow_up: |
| xds/internal/balancer/cdsbalancer/cdsbalancer.go | 82.01% <55.55%> (+0.26%) |
:arrow_up: |
Closing until a strategy for logging (etc) node ID is decided.
https://github.com/grpc/grpc-go/issues/7931