grpc-go icon indicating copy to clipboard operation
grpc-go copied to clipboard

xds client interface draft

Open purnesh42H opened this issue 1 year ago • 1 comments

purnesh42H avatar Nov 22 '24 13:11 purnesh42H

Codecov Report

Attention: Patch coverage is 0% with 1562 lines in your changes missing coverage. Please review.

Project coverage is 78.78%. Comparing base (66ba4b2) to head (1929fde). Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
xds/clients/xdsclient/authority_state.go 0.00% 466 Missing :warning:
xds/clients/xdsclient/ads_stream.go 0.00% 458 Missing :warning:
xds/clients/xdsclient/client_impl.go 0.00% 163 Missing :warning:
xds/clients/xdsclient/channel.go 0.00% 160 Missing :warning:
xds/clients/grpctransport/grpc_transport.go 0.00% 78 Missing :warning:
xds/clients/xdsclient/xdsresource/name.go 0.00% 58 Missing :warning:
xds/clients/xdsclient/client.go 0.00% 53 Missing :warning:
xds/clients/xdsclient/channel_state.go 0.00% 38 Missing :warning:
xds/clients/config.go 0.00% 26 Missing :warning:
xds/clients/xdsclient/resource_update.go 0.00% 21 Missing :warning:
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7867      +/-   ##
==========================================
- Coverage   82.04%   78.78%   -3.27%     
==========================================
  Files         377      395      +18     
  Lines       38180    39823    +1643     
==========================================
+ Hits        31326    31374      +48     
- Misses       5551     7143    +1592     
- Partials     1303     1306       +3     
Files with missing lines Coverage Δ
...al/xdsclient/xdsresource/listener_resource_type.go 85.96% <ø> (ø)
xds/clients/lrsclient/config.go 0.00% <0.00%> (ø)
xds/clients/lrsclient/lrs_client.go 0.00% <0.00%> (ø)
xds/clients/xdsclient/logging.go 0.00% <0.00%> (ø)
xds/clients/xdsclient/xdsresource/errors.go 0.00% <0.00%> (ø)
xds/clients/lrsclient/load/store.go 0.00% <0.00%> (ø)
xds/clients/xdsclient/config.go 0.00% <0.00%> (ø)
xds/clients/xdsclient/resource_update.go 0.00% <0.00%> (ø)
xds/clients/config.go 0.00% <0.00%> (ø)
xds/clients/xdsclient/channel_state.go 0.00% <0.00%> (ø)
... and 7 more

... and 39 files with indirect coverage changes

codecov[bot] avatar Nov 22 '24 14:11 codecov[bot]

Closing this as it's not an actionable PR. In the future, it's usually preferred to open a PR in your fork instead for "preview" type changes.

dfawley avatar Dec 20 '24 21:12 dfawley