grpc-go icon indicating copy to clipboard operation
grpc-go copied to clipboard

vet: add check for trailing spaces

Open purnesh42H opened this issue 1 year ago • 4 comments

RELEASE NOTES: None

purnesh42H avatar Aug 30 '24 15:08 purnesh42H

Will fix the existing files before getting this in

./xds/internal/test/e2e/run.sh:6:go test . 
./authz/grpc_authz_server_interceptors_test.go:60:			authzPolicy: `{		
./authz/grpc_authz_server_interceptors_test.go:62:				"allow_rules": 
./authz/grpc_authz_end2end_test.go:81:				"allow_rules": 
./authz/grpc_authz_end2end_test.go:169:							"headers": 
./authz/grpc_authz_end2end_test.go:173:									"values": 
./authz/grpc_authz_end2end_test.go:253:						"request": 
./security/advancedtls/testdata/server_cert_2.pem:52:            X509v3 Subject Key Identifier: 
./security/advancedtls/testdata/server_cert_2.pem:54:            X509v3 Authority Key Identifier: 
./security/advancedtls/testdata/server_cert_2.pem:57:            X509v3 Basic Constraints: 
./security/advancedtls/testdata/server_cert_2.pem:59:            X509v3 Key Usage: 
./security/advancedtls/testdata/client_cert_2.pem:52:            X509v3 Subject Key Identifier: 
./security/advancedtls/testdata/client_cert_2.pem:54:            X509v3 Authority Key Identifier: 
./security/advancedtls/testdata/client_cert_2.pem:57:            X509v3 Basic Constraints: 
./security/advancedtls/testdata/client_cert_2.pem:59:            X509v3 Key Usage: 
./security/advancedtls/testdata/server_cert_3.txt:36:            X509v3 Authority Key Identifier: 
./security/advancedtls/testdata/server_cert_3.txt:39:            X509v3 Basic Constraints: 
./security/advancedtls/testdata/server_cert_3.txt:41:            X509v3 Key Usage: 
./security/advancedtls/testdata/server_cert_3.txt:43:            X509v3 Subject Alternative Name: 
./security/advancedtls/testdata/server_cert_1.txt:52:            X509v3 Subject Key Identifier: 
./security/advancedtls/testdata/server_cert_1.txt:54:            X509v3 Authority Key Identifier: 
./security/advancedtls/testdata/server_cert_1.txt:57:            X509v3 Basic Constraints: 
./security/advancedtls/testdata/server_cert_1.txt:59:            X509v3 Key Usage: 
./security/advancedtls/testdata/server_cert_1.pem:52:            X509v3 Subject Key Identifier: 
./security/advancedtls/testdata/server_cert_1.pem:54:            X509v3 Authority Key Identifier: 
./security/advancedtls/testdata/server_cert_1.pem:57:            X509v3 Basic Constraints: 
./security/advancedtls/testdata/server_cert_1.pem:59:            X509v3 Key Usage: 
./security/advancedtls/testdata/server_cert_2.txt:52:            X509v3 Subject Key Identifier: 
./security/advancedtls/testdata/server_cert_2.txt:54:            X509v3 Authority Key Identifier: 
./security/advancedtls/testdata/server_cert_2.txt:57:            X509v3 Basic Constraints: 
./security/advancedtls/testdata/server_cert_2.txt:59:            X509v3 Key Usage: 
./security/advancedtls/testdata/server_cert_2.txt:91:         
./security/advancedtls/testdata/another_client_cert_1.pem:52:            X509v3 Subject Key Identifier: 
./security/advancedtls/testdata/another_client_cert_1.pem:54:            X509v3 Authority Key Identifier: 
./security/advancedtls/testdata/another_client_cert_1.pem:57:            X509v3 Basic Constraints: 
./security/advancedtls/testdata/another_client_cert_1.pem:59:            X509v3 Key Usage: 
./security/advancedtls/testdata/server_cert_localhost_1.pem:52:            X509v3 Subject Key Identifier: 
./security/advancedtls/testdata/server_cert_localhost_1.pem:54:            X509v3 Authority Key Identifier: 
./security/advancedtls/testdata/server_cert_localhost_1.pem:57:            X509v3 Basic Constraints: 
./security/advancedtls/testdata/server_cert_localhost_1.pem:59:            X509v3 Key Usage: 
./security/advancedtls/testdata/server_cert_localhost_1.pem:61:            X509v3 Subject Alternative Name: 
./security/advancedtls/testdata/client_cert_1.pem:52:            X509v3 Subject Key Identifier: 
./security/advancedtls/testdata/client_cert_1.pem:54:            X509v3 Authority Key Identifier: 
./security/advancedtls/testdata/client_cert_1.pem:57:            X509v3 Basic Constraints: 
./security/advancedtls/testdata/client_cert_1.pem:59:            X509v3 Key Usage: 
./examples/features/advancedtls/creds/server_cert_revoked.pem:52:            X509v3 Subject Key Identifier: 
./examples/features/advancedtls/creds/server_cert_revoked.pem:54:            X509v3 Authority Key Identifier: 
./examples/features/advancedtls/creds/server_cert_revoked.pem:56:            X509v3 Basic Constraints: 
./examples/features/advancedtls/creds/server_cert_revoked.pem:58:            X509v3 Key Usage: 
./examples/features/advancedtls/creds/server_cert_revoked.pem:60:            X509v3 Subject Alternative Name: 
./examples/features/advancedtls/creds/client_cert.pem:52:            X509v3 Subject Key Identifier: 
./examples/features/advancedtls/creds/client_cert.pem:54:            X509v3 Authority Key Identifier: 
./examples/features/advancedtls/creds/client_cert.pem:56:            X509v3 Basic Constraints: 
./examples/features/advancedtls/creds/client_cert.pem:58:            X509v3 Key Usage: 
./examples/features/advancedtls/creds/client_cert.pem:60:            X509v3 Subject Alternative Name: 
./examples/features/advancedtls/creds/server_cert.pem:52:            X509v3 Subject Key Identifier: 
./examples/features/advancedtls/creds/server_cert.pem:54:            X509v3 Authority Key Identifier: 
./examples/features/advancedtls/creds/server_cert.pem:56:            X509v3 Basic Constraints: 
./examples/features/advancedtls/creds/server_cert.pem:58:            X509v3 Key Usage: 
./examples/features/advancedtls/creds/server_cert.pem:60:            X509v3 Subject Alternative Name: 
./examples/features/advancedtls/creds/client_cert_revoked.pem:52:            X509v3 Subject Key Identifier: 
./examples/features/advancedtls/creds/client_cert_revoked.pem:54:            X509v3 Authority Key Identifier: 
./examples/features/advancedtls/creds/client_cert_revoked.pem:56:            X509v3 Basic Constraints: 
./examples/features/advancedtls/creds/client_cert_revoked.pem:58:            X509v3 Key Usage: 
./examples/features/advancedtls/creds/client_cert_revoked.pem:60:            X509v3 Subject Alternative Name: 

purnesh42H avatar Aug 30 '24 15:08 purnesh42H

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.91%. Comparing base (7fb7ac7) to head (72dd06c). Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7576      +/-   ##
==========================================
+ Coverage   81.88%   81.91%   +0.03%     
==========================================
  Files         361      361              
  Lines       27813    27813              
==========================================
+ Hits        22775    22784       +9     
+ Misses       3845     3841       -4     
+ Partials     1193     1188       -5     

see 16 files with indirect coverage changes

codecov[bot] avatar Aug 30 '24 15:08 codecov[bot]

vet: add check for trailing spaces

Release notes are for users. Only gRPC-Go developers will care about vet. None is appropriate here.

dfawley avatar Aug 30 '24 15:08 dfawley

Will fix the existing files before getting this in

./xds/internal/test/e2e/run.sh:6:go test . 
./authz/grpc_authz_server_interceptors_test.go:60:			authzPolicy: `{		
./authz/grpc_authz_server_interceptors_test.go:62:				"allow_rules": 
./authz/grpc_authz_end2end_test.go:81:				"allow_rules": 
./authz/grpc_authz_end2end_test.go:169:							"headers": 
./authz/grpc_authz_end2end_test.go:173:									"values": 
./authz/grpc_authz_end2end_test.go:253:						"request": 
./security/advancedtls/testdata/server_cert_2.pem:52:            X509v3 Subject Key Identifier: 
./security/advancedtls/testdata/server_cert_2.pem:54:            X509v3 Authority Key Identifier: 
./security/advancedtls/testdata/server_cert_2.pem:57:            X509v3 Basic Constraints: 
./security/advancedtls/testdata/server_cert_2.pem:59:            X509v3 Key Usage: 
./security/advancedtls/testdata/client_cert_2.pem:52:            X509v3 Subject Key Identifier: 
./security/advancedtls/testdata/client_cert_2.pem:54:            X509v3 Authority Key Identifier: 
./security/advancedtls/testdata/client_cert_2.pem:57:            X509v3 Basic Constraints: 
./security/advancedtls/testdata/client_cert_2.pem:59:            X509v3 Key Usage: 
./security/advancedtls/testdata/server_cert_3.txt:36:            X509v3 Authority Key Identifier: 
./security/advancedtls/testdata/server_cert_3.txt:39:            X509v3 Basic Constraints: 
./security/advancedtls/testdata/server_cert_3.txt:41:            X509v3 Key Usage: 
./security/advancedtls/testdata/server_cert_3.txt:43:            X509v3 Subject Alternative Name: 
./security/advancedtls/testdata/server_cert_1.txt:52:            X509v3 Subject Key Identifier: 
./security/advancedtls/testdata/server_cert_1.txt:54:            X509v3 Authority Key Identifier: 
./security/advancedtls/testdata/server_cert_1.txt:57:            X509v3 Basic Constraints: 
./security/advancedtls/testdata/server_cert_1.txt:59:            X509v3 Key Usage: 
./security/advancedtls/testdata/server_cert_1.pem:52:            X509v3 Subject Key Identifier: 
./security/advancedtls/testdata/server_cert_1.pem:54:            X509v3 Authority Key Identifier: 
./security/advancedtls/testdata/server_cert_1.pem:57:            X509v3 Basic Constraints: 
./security/advancedtls/testdata/server_cert_1.pem:59:            X509v3 Key Usage: 
./security/advancedtls/testdata/server_cert_2.txt:52:            X509v3 Subject Key Identifier: 
./security/advancedtls/testdata/server_cert_2.txt:54:            X509v3 Authority Key Identifier: 
./security/advancedtls/testdata/server_cert_2.txt:57:            X509v3 Basic Constraints: 
./security/advancedtls/testdata/server_cert_2.txt:59:            X509v3 Key Usage: 
./security/advancedtls/testdata/server_cert_2.txt:91:         
./security/advancedtls/testdata/another_client_cert_1.pem:52:            X509v3 Subject Key Identifier: 
./security/advancedtls/testdata/another_client_cert_1.pem:54:            X509v3 Authority Key Identifier: 
./security/advancedtls/testdata/another_client_cert_1.pem:57:            X509v3 Basic Constraints: 
./security/advancedtls/testdata/another_client_cert_1.pem:59:            X509v3 Key Usage: 
./security/advancedtls/testdata/server_cert_localhost_1.pem:52:            X509v3 Subject Key Identifier: 
./security/advancedtls/testdata/server_cert_localhost_1.pem:54:            X509v3 Authority Key Identifier: 
./security/advancedtls/testdata/server_cert_localhost_1.pem:57:            X509v3 Basic Constraints: 
./security/advancedtls/testdata/server_cert_localhost_1.pem:59:            X509v3 Key Usage: 
./security/advancedtls/testdata/server_cert_localhost_1.pem:61:            X509v3 Subject Alternative Name: 
./security/advancedtls/testdata/client_cert_1.pem:52:            X509v3 Subject Key Identifier: 
./security/advancedtls/testdata/client_cert_1.pem:54:            X509v3 Authority Key Identifier: 
./security/advancedtls/testdata/client_cert_1.pem:57:            X509v3 Basic Constraints: 
./security/advancedtls/testdata/client_cert_1.pem:59:            X509v3 Key Usage: 
./examples/features/advancedtls/creds/server_cert_revoked.pem:52:            X509v3 Subject Key Identifier: 
./examples/features/advancedtls/creds/server_cert_revoked.pem:54:            X509v3 Authority Key Identifier: 
./examples/features/advancedtls/creds/server_cert_revoked.pem:56:            X509v3 Basic Constraints: 
./examples/features/advancedtls/creds/server_cert_revoked.pem:58:            X509v3 Key Usage: 
./examples/features/advancedtls/creds/server_cert_revoked.pem:60:            X509v3 Subject Alternative Name: 
./examples/features/advancedtls/creds/client_cert.pem:52:            X509v3 Subject Key Identifier: 
./examples/features/advancedtls/creds/client_cert.pem:54:            X509v3 Authority Key Identifier: 
./examples/features/advancedtls/creds/client_cert.pem:56:            X509v3 Basic Constraints: 
./examples/features/advancedtls/creds/client_cert.pem:58:            X509v3 Key Usage: 
./examples/features/advancedtls/creds/client_cert.pem:60:            X509v3 Subject Alternative Name: 
./examples/features/advancedtls/creds/server_cert.pem:52:            X509v3 Subject Key Identifier: 
./examples/features/advancedtls/creds/server_cert.pem:54:            X509v3 Authority Key Identifier: 
./examples/features/advancedtls/creds/server_cert.pem:56:            X509v3 Basic Constraints: 
./examples/features/advancedtls/creds/server_cert.pem:58:            X509v3 Key Usage: 
./examples/features/advancedtls/creds/server_cert.pem:60:            X509v3 Subject Alternative Name: 
./examples/features/advancedtls/creds/client_cert_revoked.pem:52:            X509v3 Subject Key Identifier: 
./examples/features/advancedtls/creds/client_cert_revoked.pem:54:            X509v3 Authority Key Identifier: 
./examples/features/advancedtls/creds/client_cert_revoked.pem:56:            X509v3 Basic Constraints: 
./examples/features/advancedtls/creds/client_cert_revoked.pem:58:            X509v3 Key Usage: 
./examples/features/advancedtls/creds/client_cert_revoked.pem:60:            X509v3 Subject Alternative Name: 

ALL FIXED in follow up commit

purnesh42H avatar Aug 30 '24 19:08 purnesh42H