grpc-go icon indicating copy to clipboard operation
grpc-go copied to clipboard

protoc-gen-go-grpc: Update README.md file

Open keita127 opened this issue 1 year ago • 2 comments

I have found these two previous PRs (https://github.com/grpc/grpc-go/pull/4538 https://github.com/grpc/grpc-go/pull/5158) and have also confirmed that the following code actually works.

protoc --go-grpc_out=require_unimplemented_servers=false:. \ foo.proto

However, since go-grpc_out and go-grpc_opt are written separately as the protoc command options on the quick start guide, isn't this easier to understand?

RELEASE NOTES: N/A

keita127 avatar Jun 05 '23 16:06 keita127

CLA Missing ID CLA Not Signed

  • :x: The email address for the commit (013cbf58fc2846b1ec2e7687bea21ab1e8b8fb9b) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

Hello, can you please sign the CLA before we can take a look.

zasweq avatar Jun 06 '23 17:06 zasweq

/easycla

keita127 avatar Jun 07 '23 13:06 keita127

Thanks for checking. However, I believe I have already signed the CLA. Please let me know if I am wrong. Also, since tests (tests, 1.20, arm64) have failed, could you please re-run it? I don't think this is caused by my change since I only changed the README.

keita127 avatar Jun 07 '23 14:06 keita127