grpc-go icon indicating copy to clipboard operation
grpc-go copied to clipboard

Published 20 hours ago • verified publisher icon grpc

internal/grpcsync: Provide an internal-only pub-sub type API

Open my4-dev opened this issue 2 years ago • 8 comments

This PR adds an internal-only generic pub-sub type API.

Please refer to this conversation in https://github.com/grpc/grpc-go/pull/6036 .

RELEASE NOTES: none

my4-dev avatar Apr 01 '23 06:04 my4-dev

@my4-dev : Thanks for doing this.

easwars avatar Apr 03 '23 23:04 easwars

I've finished incorporating our ideas. Please take a look at this. Thank you.

my4-dev avatar Apr 06 '23 15:04 my4-dev

@easwars : Thank you for your suggestion. I've corrected.

my4-dev avatar Apr 10 '23 14:04 my4-dev

Hi, @easwars . Thank you for your thoughtful advice. I've corrected my test codes. I also have deleted TestPubSub_PublishOneMsg and TestPutSub_PubslishMultiMsgs_RegisterMultiSubs because these tests point of views are included in TestPutSub_PublishMsgs_RegisterSubs_And_Stop.

my4-dev avatar Apr 15 '23 07:04 my4-dev

This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.

github-actions[bot] avatar May 02 '23 01:05 github-actions[bot]

We are trying to move away from blocking sends on channel in our tests because if the test is flaky or if there is a bug in the code which makes the test fail, such blocking sends can sometimes lead to the test hanging. This means that the test will fail only when the timeout passed to go test expires. We want tests to run quickly and fail quickly. So, please don't use a blocking send here. If your test is failing because of this change, you will have to figure out why it is failing and fix it appropriately.

Thank you for your advice. I figured out the coding concepts in this repo. I fixed not to use blocking send in test cases.

my4-dev avatar May 11 '23 12:05 my4-dev

This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.

github-actions[bot] avatar May 17 '23 12:05 github-actions[bot]

@arvindbr8 is out of town until when @easwars gets back so reassigning to @easwars.

dfawley avatar May 31 '23 20:05 dfawley

@easwars : Thank you for approving this PR! I've fixed pubsub_test according to your advice.

my4-dev avatar Jun 27 '23 13:06 my4-dev

@my4-dev : Thanks for taking care of all the comments.

@arvindbr8 : Could you please be the second reviewer on this one. Thanks.

easwars avatar Jun 27 '23 16:06 easwars