grpc-go icon indicating copy to clipboard operation
grpc-go copied to clipboard

ringhash: improve test coverage

Open easwars opened this issue 1 year ago • 9 comments

I just noticed that the amount of tests that we have for the ringhash LB policy is woefully short compared to what C-core and Java have. We should add more tests, which exercise different scenarios.

C-core tests are here: https://github.com/grpc/grpc/blob/master/test/cpp/end2end/xds/xds_ring_hash_end2end_test.cc Java tests are here: https://github.com/grpc/grpc-java/blob/master/xds/src/test/java/io/grpc/xds/RingHashLoadBalancerTest.java

easwars avatar Mar 02 '23 17:03 easwars

I would like to contribute, can you assign this to me.

avinilcodes avatar Sep 26 '23 03:09 avinilcodes

@avinilcodes - I can gladly assign this to you, but right now it seems very ambiguous. Do you think you'll be able to assess the tests in our repo and compare it to the tests in the other repos, or would you need us to help identify the missing things more concretely?

dfawley avatar Sep 26 '23 16:09 dfawley

Hi @dfawley , I can work on this.

shashank-priyadarshi avatar Oct 01 '23 20:10 shashank-priyadarshi

@shashank-priyadarshi as @dfawley mentioned earlier, do you think you'll be able to assess the tests in our repo and compare it to the tests in other repos, or would you need us help identify the missing things more concretely?

ginayeh avatar Oct 03 '23 19:10 ginayeh

@shashank-priyadarshi / @avinilcodes -- friendly ping! We are almost half way through "Hacktoberfest" 😄.

arvindbr8 avatar Oct 16 '23 20:10 arvindbr8

Sorry, been busy with work lately, couldn't squeeze this in! Hopefull about the weekend!

shashank-priyadarshi avatar Oct 17 '23 06:10 shashank-priyadarshi

This lines up well with some work I have in progress on improving ring hash, and such tests would actually help me, so I'm assigning to me.

atollena avatar May 21 '24 16:05 atollena

There are more tests to be written :)

easwars avatar Jun 12 '24 00:06 easwars

This work uncovered https://github.com/grpc/grpc-go/issues/7363.

atollena avatar Jun 28 '24 07:06 atollena