grpc-go icon indicating copy to clipboard operation
grpc-go copied to clipboard

Published 20 hours ago • verified publisher icon grpc

server: with TLS, TCP user timeout is not set on the underlying connection

Open costinm opened this issue 1 year ago • 5 comments

https://github.com/grpc/grpc-go/blob/60eecd9169ddc74ee6cf4bd52e2e06ef6766c5b7/internal/transport/http2_server.go#L235

I was looking at the write code - for net.Conn this works as expected, but if TLS is used conn will be tls.Conn so the line will not set a timeout. I would guess rawconn should be passed ?

costinm avatar Sep 08 '22 15:09 costinm

Unassigning; I thought this was client-side, but it looks like the client is done correctly and only the server needs to be fixed. I probably don't have cycles for this right now.

dfawley avatar Oct 18 '22 19:10 dfawley

@zasweq @dfawley Hello! I could look into this issue if it's still available for fix. If it's ok, please feel free to assign it to me. Thanks

tobotg avatar May 14 '23 22:05 tobotg

Sure, that would be great if you have time for it!

dfawley avatar May 15 '23 23:05 dfawley

@dfawley I've been very busy lately, hopefully I'll be able to give it a look during the weekend.

tobotg avatar May 23 '23 12:05 tobotg

@dfawley I've just submitted a PR now. Please have a look when you get a chance. Thanks

tobotg avatar May 27 '23 07:05 tobotg