grpc-dotnet icon indicating copy to clipboard operation
grpc-dotnet copied to clipboard

Add version conditions for Microsoft.Extensions.Http and Microsoft.Extensions.Logging.Abstractions

Open ArminShoeibi opened this issue 2 years ago • 4 comments

This merge request adds some conditions in Grpc.Net.Client.csproj and Grpc.Net.ClientFactory.csproj. Actually, this merge request solves this problem.

image

Thank you in advance.

ArminShoeibi avatar Dec 16 '21 16:12 ArminShoeibi

CLA Not Signed

What does this fix? The older version is forward compatible, and a .NET 6 app can specify to use version 6 of that Microsoft.Extensions library if it wants.

JamesNK avatar Dec 16 '21 21:12 JamesNK

What does this fix? The older version is forward compatible, and a .NET 6 app can specify to use version 6 of that Microsoft.Extensions library if it wants.

Yes, you told me this before, but not everyone knows this. They just install without attention, by the way with this merge request we don't need to install those packages explicitly.

ArminShoeibi avatar Dec 16 '21 21:12 ArminShoeibi

Ok. Usually referencing the lowest version is recommended. However, there are some advantages of bringing in a new version.

Let me talk with some other .NET people. I will see what the general approach is here.

JamesNK avatar Dec 16 '21 21:12 JamesNK

https://github.com/grpc/grpc-dotnet/pull/2021 updates the dependencies to .NET 6

JamesNK avatar Aug 15 '23 02:08 JamesNK