grpc-dart
grpc-dart copied to clipboard
update: Migrate off legacy JS/HTML apis
The purpose of this PR is to fix the issue mentioned in #715, I have test both unary/server side stream requests on canvaskit/wasm platform.Thanks to @hyunw55 `s comment in https://github.com/grpc/grpc-dart/issues/715#issuecomment-2133525797.
Main updates include:
- add web v1.0.0 package and
XMLHttpRequestto replace html package. - use
dart.library.ioto determine the current platform.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: minoic / name: minoic (2cda92b73cc8fe5426ba2ec3336e0ed50637d819, 05756b736fab8dbbf193ae68e4867bda960dc041, b96174d219e90ccf6e516e6d7f39a6f4ee9f4416, c424253a30bebadb5ffd05533068631e29a03285, 4621ac7a7fcd1ae4159e58cb554c7712962fce7f, 3d9ee25fee6d398489816927ffe219408d778ae4)
@kevmoo do you happen to know who would be the right maintainers to look at this?
Thanks for chiming in here @aran And thanks for the PR @minoic
I'll work to find a reviewer!
PR Health
Breaking changes :heavy_check_mark:
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| grpc | Non-Breaking | 4.0.2-wip | 4.0.2-wip | 4.0.2-wip | :heavy_check_mark: |
Changelog Entry :heavy_check_mark:
| Package | Changed Files |
|---|
Changes to files need to be accounted for in their respective changelogs.
Coverage :warning:
| File | Coverage |
|---|---|
| lib/grpc_or_grpcweb.dart | :green_heart: 57 % |
| lib/src/client/transport/xhr_transport.dart | :broken_heart: Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
API leaks :warning:
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbols |
|---|---|
| grpc | Any $1.Duration ServerHandler |
This check can be disabled by tagging the PR with skip-leaking-check.
Package publish validation :heavy_check_mark:
| Package | Version | Status |
|---|---|---|
| package:grpc | 4.0.2-wip | WIP (no publish necessary) |
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.
We published a new pkg:web with those HTTP helpers
We need to rebase this fix, too
looks like we need to do another merge here
@kevmoo see #747 for an attempt to push this forward.
Closing in favor of #747