grpc-dart icon indicating copy to clipboard operation
grpc-dart copied to clipboard

Add stacktrace to deadline exceeded error.

Open tarobins opened this issue 2 years ago • 4 comments

BUG: https://github.com/grpc/grpc-dart/issues/573

tarobins avatar Sep 02 '22 21:09 tarobins

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: tarobins / name: Tom Robinson (58e952077730e73c2816baf2e6fe0e2a78605693)

If you have suggestions on how to test this change, please let me know.

tarobins avatar Sep 02 '22 21:09 tarobins

@tarobins does attaching this stack trace actually communicate any additional information? It's always going to be the same: a bunch of internal frames related to the timer implementation and the ClientCall._onTimedOut frame at the top.

mraleph avatar Sep 05 '22 08:09 mraleph

@mraleph

Yes, you are correct. I thought I saw something useful when I was testing the change, but perhaps I was just overly optimistic.

On the other hand, I spent a bunch of time trying to figure out why there was no stack trace. Had I seen the, even not particularly useful, one that this change provides, I would have at least understood where the error was appearing in the grpc library code rather than chasing why there was no stack trace. That said, I'm going to see if I can improve the situation more, so no need for you to review this change further right now.

Thanks.

tarobins avatar Sep 05 '22 17:09 tarobins

Closing as stale for now.

mraleph avatar Dec 12 '22 08:12 mraleph