protoc-gen-grpc-gateway-ts icon indicating copy to clipboard operation
protoc-gen-grpc-gateway-ts copied to clipboard

renderURLSearchParams doesn't render BoolValue and other well-known wrapper types correctly

Open seanami opened this issue 2 years ago • 2 comments

I have a request message with google.protobuf.BoolValue name = 1 as a field. When I define a value for this field in Typescript like name: { value: false }, then I see that the request made by the generated code does not include the parameter for this field.

It appears that renderURLSearchParams strips out all primitive types with zero values, but that's not expected for BoolValue, since the whole point is to be able to differentiate between false and nil.

Is there an established way to fix issues like this within this library? I see https://github.com/grpc-ecosystem/protoc-gen-grpc-gateway-ts/issues/25 and https://github.com/cresta/protoc-gen-grpc-gateway-ts/pull/1, but it doesn't include BoolValue or the other wrapper well-known types.

seanami avatar Mar 21 '23 18:03 seanami