polyglot icon indicating copy to clipboard operation
polyglot copied to clipboard
verified publisher icon grpc-ecosystem

oauth config override

Open peteboothroyd opened this issue 8 years ago • 2 comments

Adding ability to override oauth configuration settings via command line arguments

  • Added args: oauth_refresh_token_endpoint_url, oauth_client_id, oauth_client_secret, oauth_refresh_token_path, oauth_access_token_path
  • These overwrite the corresponding data in the config files
  • Added tests for new args
  • Added logging for case where poylglot hangs waiting for stdin

peteboothroyd avatar Aug 31 '17 14:08 peteboothroyd

I've reformatted the tabs. Is there an automated way this could be done, maybe with a linter to check style?

peteboothroyd avatar Sep 02 '17 00:09 peteboothroyd

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot avatar Sep 02 '17 00:09 googlebot