grpc-spring icon indicating copy to clipboard operation
grpc-spring copied to clipboard

Published 20 hours ago • verified publisher icon grpc-ecosystem

Autoconfigure for updated Sleuth Brave class

Open clamey opened this issue 2 years ago • 1 comments

Between Sleuth 2.x and 3.x, the Brave Auto Configuration class package and name changed. This updates the GrpcCommonTraceAutoConfiguration to wait to load after either version is present.

Currently, people who try to use Sleuth 3.x and grpc-spring-boot-starter might run into problems, like I did, if GrpcCommonTraceAutoConfiguration runs first. It will create the grpcTracing bean, and then BraveAutoConfiguration will try to create a bean with the same name and fail.

clamey avatar Dec 22 '22 20:12 clamey

Probably duplicated in #829?

dsyer avatar Mar 19 '23 09:03 dsyer

Could you please fix the merge conflict?

ST-DDT avatar Mar 14 '24 09:03 ST-DDT

#829 was merged. Isn’t this redundant now?

dsyer avatar Mar 14 '24 09:03 dsyer

Yes you are right.

Closing as obsolete

ST-DDT avatar Mar 14 '24 10:03 ST-DDT