grpc-spring icon indicating copy to clipboard operation
grpc-spring copied to clipboard

Add properties to enable/disable each metric

Open pluttrell opened this issue 3 years ago • 2 comments

Please consider adding a property to enable/disable each of the three metric's that are generated for both client & server support. Users might not find utility in one and thus might want an easy way to disable it.

pluttrell avatar Jun 14 '22 07:06 pluttrell

Once again: Please also report/request that feature there as we will eventually switch to that one. https://github.com/micrometer-metrics/micrometer/tree/main/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/grpc

ST-DDT avatar Jun 14 '22 07:06 ST-DDT

A Micrometer PR has been added to enable customization of the classes in Micrometer itself.

For this PR (in this starter repo), I'm hoping we can add configurable Spring Boot properties to configure these. I wonder if something like the following might make sense:

grpc:
  server:
    metrics:
      processing-duration:
        enabled: true

pluttrell avatar Jun 15 '22 07:06 pluttrell

Since we are going to switch to the micrometer one in the next version, we won't implement this feature here for now.

ST-DDT avatar Aug 25 '22 13:08 ST-DDT