grpc-spring icon indicating copy to clipboard operation
grpc-spring copied to clipboard
verified publisher icon grpc-ecosystem

merge GrpcMetadtaxxxConfiguration

Open Cczzzz opened this issue 4 years ago • 4 comments

#564

Cczzzz avatar Jul 26 '21 06:07 Cczzzz

Looks good to me. I'll do an in depth review after my holidays (two weeks).

ST-DDT avatar Jul 26 '21 06:07 ST-DDT

Please run ./gradlew spotlessApply and commit the generated changes. Also please rename GrpcMetadataConfiguration to GrpcCloudMetadataConfiguration.

ST-DDT avatar Aug 03 '21 21:08 ST-DDT

请运行./gradlew spotlessApply并提交生成的更改。 也请重命名GrpcMetadataConfiguration为GrpcCloudMetadataConfiguration.

ok

Cczzzz avatar Aug 06 '21 11:08 Cczzzz

This failed for Eureka for me. I'll have another look at it soon.

ST-DDT avatar Aug 22 '21 19:08 ST-DDT