grpc-spring icon indicating copy to clipboard operation
grpc-spring copied to clipboard

Add example for sleuth and zipkin integration #264

Open haochencheng opened this issue 4 years ago • 5 comments

Hello.I see #264 is marked help wanted . I add examples:cloud-sleuth-zipkin-grpc-client and examples:cloud-sleuth-zipkin-grpc-server which integration sleuth and zipkin .

image image

haochencheng avatar Jul 24 '21 14:07 haochencheng

Sorry for the late response. I have been on vacation.

This looks good to me. I will do a thorough review in the next few days.

ST-DDT avatar Aug 03 '21 21:08 ST-DDT

Could you please provide a docker command to run the sleuth/zipkin server locally, so that I can run it on my computer without installing sleuth/zipkin there?

ST-DDT avatar Aug 03 '21 21:08 ST-DDT

Could you please provide a docker command to run the sleuth/zipkin server locally, so that I can run it on my computer without installing sleuth/zipkin there?

here is the docker command to install zipkin

docker pull openzipkin/zipkin
docker run --name zipkin -p 9411:9411 openzipkin/zipkin

image

then open http://127.0.0.1:9411/ you could see the zipkin ui image

haochencheng avatar Aug 05 '21 07:08 haochencheng

I got 2 server spans after adding GrpcSleuthServerConfig. Called from BloomRPC (a GUI tool for GRPC).

Sorry for my ignorance, but may I ask what's the point of GrpcSleuthServerConfig? Without it, the tracing also works by just adding brave-instrumentation-grpc dependency.

image

masayoshi-louis avatar Oct 15 '21 08:10 masayoshi-louis

@masayoshi-louis is right. These beans will be created automatically by this library and thus don't need to be created in the example projects again.

@haochencheng Sorry for the delay with my reviews. I'm currently very busy and don't have any spare time.

It's ok.These beans are redundant,i add these beans want people know that them can customer the beans.The example should by simple and concise. I will do a recheck and remove these benas.

haochencheng avatar Oct 17 '21 05:10 haochencheng