go-grpc-prometheus
go-grpc-prometheus copied to clipboard
grpc-ecosystem
Version 2 - promgrpc merge
I'm the author of promgrpc (that, in fact, is using a lot of code from this repository). In reply to https://github.com/grpc-ecosystem/go-grpc-prometheus/issues/37#issuecomment-429737667 I would like to know if you are open to incorporate my version into your codebase/organization.
More about differences can be found here: https://github.com/grpc-ecosystem/go-grpc-prometheus/issues/37#issuecomment-428958682.
It would solve:
- Decouple registration from grpc.Server implementation #17.
- Implementing the grpc-go/stats.Handler interface #36.
- Potentially #49 as well (if the name would be kept).
@bwplotka how do you feel about this? I think in open in general about this. Of course we’ll want to go through things in detail but I do think there are a lot of good things in there and it would be nice to have a canonical lib.
Of couse. I believe that there is a lot more value in making one thing better than having 2 separate implementations that does the same thing (:
I'm glad to read that! I'm about to prepare a pull request. I'm wondering what would be the preferred way of doing it. Complete override, submodule or maybe a separate repo. Once PR is prepared we could go through it and change/adjust what is needed.
I would say 3th option - merging (: Adopting your improvements here? Is that an option?
@bwplotka It could be an option. To make it an iterative process separate v2 branch would be helpful. Then I could start to move features one by one.
Here you go: https://github.com/grpc-ecosystem/go-grpc-prometheus/tree/draft-v2.0.0