go-grpc-prometheus

go-grpc-prometheus copied to clipboard

[doc] fix the example code typo

1

Signed-off-by: Ziqi Zhao Fix the example code typo in case of confusion.

fatsheep9146

Get rid of serverHandledHistogramEnabled and associated race condition

3

Duplicate of #109 with CLAs fixed.

roboslone

docs inconsistency: Histograms doesn't include grpc_code

8

Hi, unlike the documentation in the README file, it appairs that the grpc_code is not included as label in the histogram. ``` grpc_server_handling_seconds_bucket - contains the counts of RPCs by...

NBR41

Add GRPCServer interface to accept different grpc.Server implementations

1

This lets register any grpc server implementation, e.g. `*xds.GRPCServer`

amenzhinsky

Is there a way to enable `grpc_server_handling_seconds_sum` and `grpc_server_handling_seconds_count`, so one can do aggregations and computations of average latency: ``` grpc_server_handling_seconds_sum{grpc_code="OK",grpc_method="PingList",grpc_service="mwitkow.testproto.TestService",grpc_type="server_stream"} 0.0003866430000000001 grpc_server_handling_seconds_count{grpc_code="OK",grpc_method="PingList",grpc_service="mwitkow.testproto.TestService",grpc_type="server_stream"} 1 ... ``` without the full blown...

baryluk

docs: fix typo in README

2

zepatrik

Do not unwrap errors by causer interface

2

github.com/pkg/errors [since version 0.9.0](https://github.com/pkg/errors/releases/tag/v0.9.0) [already supports](https://github.com/pkg/errors/blob/master/errors.go#L163) native error wrapping added in Go 1.13

gaiaz-iusipov

Add optional histogram of msg size.

8

It would be useful to see e.g avg message size for the frame. If we want this then for AC: Add histograms (optional): * grpc_server_msg_size_received_bytes * grpc_client_msg_size_received_bytes * grpc_server_msg_size_sent_bytes *...

bwplotka

Hi there. This might be an unusual "issue" beeing reported. There has been a security incident in codecov.io with the bash-uploader script (see [1] for details) which potentially exposed secrets...

robert-heinzmann-logmein

Use stats handler instead of interceptor and add message size histograms

8

Hi guys, Working on [#85 ](https://github.com/grpc-ecosystem/go-grpc-prometheus/issues/85) I add stats_handlers on server-side and client side, there is some question need discuss with you: 1. In the stats.Handler, I can't distinguish between...

tonywang