go-grpc-middleware icon indicating copy to clipboard operation
go-grpc-middleware copied to clipboard

Is there any docs about using github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus in middleware v2

Open wrapupc opened this issue 1 year ago β€’ 3 comments

Api in github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus is quite different from https://github.com/grpc-ecosystem/go-grpc-prometheus, and i didn't find any guidance of how to use it. Is is still in progress?

wrapupc avatar Apr 11 '23 14:04 wrapupc

No, it's ready to use. You can see example here. Where would you expect the examples/documentation?

I think it's fair to add migration guide to README, let's do that πŸ‘πŸ½

Thanks for feedback! Api should allow similar (and more) functionalities.

bwplotka avatar Apr 13 '23 10:04 bwplotka

Thanks for reply , looking forward to the guideπŸ˜€

Bartlomiej Plotka @.***>于2023εΉ΄4月13ζ—₯ 周四18:48ε†™ι“οΌš

No, it's ready to use. You can see example here https://github.com/grpc-ecosystem/go-grpc-middleware/blob/main/examples/server/main.go#L140. Where would you expect the examples/documentation?

I think it's fair to add migration guide to README, let's do that πŸ‘πŸ½

Thanks for feedback! Api should allow similar (and more) functionalities.

β€” Reply to this email directly, view it on GitHub https://github.com/grpc-ecosystem/go-grpc-middleware/issues/558#issuecomment-1506750223, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZOOBJDCITE4OYGD3UC2NWDXA7KWFANCNFSM6AAAAAAW2L5AOM . You are receiving this because you authored the thread.Message ID: @.***>

wrapupc avatar Apr 13 '23 15:04 wrapupc

@bwplotka Do you know if the migration guide was added in the end? I can't find it anywhere.

Since the go-grpc-prometheus package used global vars/package imports to do metric registration, it means we can't support both old and new package to stagger the migration and need to do a complete cutover. Is it safe to assume the new package is a straight replacement and there are no breaking changes, otherwise it makes it difficult to test the migration to new package?

Thanks!

abhimanyuchugh avatar Nov 07 '23 15:11 abhimanyuchugh