go-grpc-middleware icon indicating copy to clipboard operation
go-grpc-middleware copied to clipboard

Published 20 hours ago • verified publisher icon grpc-ecosystem

Upgrade validator.

Open regeda opened this issue 4 years ago • 6 comments

protoc-gen-validate is release under the v0.6.2:

https://github.com/envoyproxy/protoc-gen-validate/releases/tag/v0.6.2

The release contains the merge PR about "multi-error validation with ValidateAll()":

https://github.com/envoyproxy/protoc-gen-validate/pull/468

regeda avatar Oct 22 '21 22:10 regeda

Do we not version this anywhere? Someone else could come along and regenerate these files with their own version. We should version the generator somewhere.

Do you mean this file testing/testproto/test.manual_validator.pb.go?

regeda avatar Oct 24 '21 15:10 regeda

Sorry, I mean the version of the generator that generates the file. The versions of protoc-gen-validate.

johanbrandhorst avatar Oct 24 '21 17:10 johanbrandhorst

sorry for the noise, but what's the status here? Would be great to have this merged 🎉

mweibel avatar Dec 17 '21 10:12 mweibel

We added support for ValidateAll in v2 here: https://github.com/grpc-ecosystem/go-grpc-middleware/commit/5b8ad84c13c447ced1e1ebfd72fb3b5e79b45bdc. If that's what this is about we can close this.

johanbrandhorst avatar Dec 17 '21 17:12 johanbrandhorst

yes, it's about that :+1: I didn't know about v2 yet, is that usable yet?

mweibel avatar Dec 20 '21 12:12 mweibel

It should be useable, yeah, but we haven't made stable release version of it yet. There are a few oustanding issues still 😬. https://github.com/grpc-ecosystem/go-grpc-middleware/issues?q=is%3Aissue+is%3Aopen+v2+label%3Av2

johanbrandhorst avatar Dec 20 '21 13:12 johanbrandhorst