glow icon indicating copy to clipboard operation
glow copied to clipboard

Nit: std::collections::HashSet

Open mooman219 opened this issue 3 years ago • 2 comments

I noticed this library uses std::collections::HashSet. Is there a reason for that over hashbrown::HashSet? Standard's implementation is backed by hashbrown, so functionally there's no difference. The current code forces a std import.

mooman219 avatar Jan 27 '22 05:01 mooman219

The issue (I think?) is that, if you use hashbrown, you bring in not only that crate as a dependency, but also whatever hasher you decide to use with it. If that isn't an issue, I would support using hashbrown for no_std.

notgull avatar Mar 08 '23 01:03 notgull

Another question is whether another collection type might be possible here, e.g. change to use BTreeSet (or even Vec), in which case you'd only need alloc.

ajtribick avatar Jul 06 '23 18:07 ajtribick