GroupButler icon indicating copy to clipboard operation
GroupButler copied to clipboard

Idea: Declare disabled plugins on config instead of listing all enabled plugins

Open yangm97 opened this issue 7 years ago • 2 comments

This probably would require something like lfs, but it would make disabling plugins easier. We could then use an env var like $DISABLED_PLUGINS containing a json array of disabled plugins to actually disable a plugin.

The same could be made with multipurpose plugins.

yangm97 avatar Jul 30 '17 22:07 yangm97

I don't think something like this belongs in the main config anyway. As always, I'm not a big fan of ENV vars for complex config.

NotAFile avatar Jul 31 '17 14:07 NotAFile

I think I could add support for a config.json too. Config load order would be:

  1. Secret file (/run/secrets/something), in case of telegram token, webhook custom cert, postgres password, etc;
  2. Env var;
  3. config.json;
  4. Default value (config.lua).

I think it’s important to allow customising most, if not all of config.lua contents so other people can adapt GB to their needs (without having to modify files that aren’t git ignored).

On an unrelated note, once I finish the Postgres PR, many “unrelated” settings should vanish from config.lua, with defaults being available at the database schema.

yangm97 avatar Jul 31 '17 17:07 yangm97