Gary Roumanis

Results 54 comments of Gary Roumanis

We could support an optional parameter for a sort method but I'm not sure how useful that will be. I imagine the vast majority, if not all use cases, will...

I like the latter assuming a future that completes after the request has completed doesn't cause an issue.

ACX does not make use of `isSameErrorZone` and `errorZone`. However, it does make use of a custom `handleUncaughtError` function that exposes them to users through a public API with a...

Considering, > Thanks to a lot of help from @a-siva, @iinozemtsev, @godofredoc, and @athomas, this change has now been tested throughly, both in Google's internal codebase and in the open...

What a wonderful set of write ups. I'm truly impressed and thank you! I don't own any of this infrastructure so I can't provide a proper review but I did...

I like the idea of `doesNotEmitFor(Duration)`. As an alternative you can do something like this today: ```Dart test('timeout test', () async { var completer = Completer(); expect(completer.future.timeout(Duration(seconds: 1)), throwsA(TypeMatcher())); });...

You can use `toList()` on a `Stream` to likely get the behavior your want. For example: ```Dart test('timeout test', () async { var controller = StreamController(); expect(controller.stream.toList().timeout(Duration(seconds: 1)), throwsA(TypeMatcher())); });...

Neat! > I wonder if people will get it confused with && though as this almost reads like a boolean now except with only one &? Yeah I wonder the...

`package:coverage` can consume these files and output into the lcov format. I believe the command is `format_coverage`. See the readme: https://github.com/dart-lang/coverage