Fenix Routes Blacklist

[pantierra]

Hi,

in code there is a blacklist of some routes hard-coded into the script. Are these from a different network? Or is there any other reason they are excluded. I'd suggest to mark them in the data of OSM to be able to sort them out, and removing the blacklist in code.

[pantierra]

For now I added (in OSM) network=BR-Floripa to all relations you are extracting. Only the hard-coded blacklisted relations I left without the network tag. This allows to query the data you need at once, without further cleanup.

But still I'm not sure why these are blacklisted. So, no idea if excluding them from the network is the proper way to go, or if we should tag them differently to explain their nature of being blacklisted.

[grote]

The blacklist includes routs which are not properly mapped and would produce wrong schedules. That is why they are being excluded from the schedule generation. They are however part of the same network.

Thanks for editing OSM to add a network tag. Could you please change the network to SIM and while you are at it also add the public_transport:version tag?

I am not sure OSM is the best place for storing information for excluding routes, but you probably know this better than me. Maybe there's a todo or unfinished or wip (work-in-progress) tag that can be used to exclude routes. If that is fine, we could go with this.

[pantierra]

• public_transport:version=2 I already added to all.
• Changing to SIM is not a problem, will do and report here.
• If routes are not ready to be used, I would use the common fixme=* tag and then exclude route with this one set on the query.

btw, I saw the data about a lot of routes of the SIM network in OSM is improvable ;)

[grote]

If routes are not ready to be used, I would use the common fixme=* tag and then exclude route with this one set on the query

Sounds like a good idea to me.

I saw the data about a lot of routes of the SIM network in OSM is improvable ;)

It sure is. The community here is limited, I'm trying to get more people involved who can help with this. My primary focus so far has not been on improving OSM data, but generating the GTFS file.

[pantierra]

Here you go:

• All routes are tagged as network=SIM
• All routes are tagged as public_transport:version=2
• The blacklisted routes are tagges with fixme=gtfs_generation_problems

Closing here.

[grote]

Thanks a lot! :)

[pantierra]

Opened to actually respect this in Fenix implementation (config file query tags) and remove blacklist removing loop in TripsCreatorFenix

[pantierra]

This is effecting the tests for br_florianopolis (former fenix) which have a related workaround in #135 by implementing/overriding test_refresh_routes_cache().